Hesham/wireguard-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: remove TODO name graffiti

Browse Source 
Googlers have a habit of graffiting their name in TODO items that then
are never addressed, and other people won't go near those because
they're marked territory of another animal. I've been gradually cleaning
these up as I see them, but this commit just goes all the way and
removes the remaining stragglers.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2021-02-22 15:43:08 +01:00
parent 9a29ae267c
commit f9dac7099e
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
device/noise-protocol.go
View File

@ -20,7 +20,6 @@ import (
type handshakeState int type handshakeState int
// TODO(crawshaw): add commentary describing each state and the transitions
const ( const (
handshakeZeroed = handshakeState(iota) handshakeZeroed = handshakeState(iota)
handshakeInitiationCreated handshakeInitiationCreated

2
device/send.go
View File

@ -421,7 +421,7 @@ func (peer *Peer) RoutineSequentialSender() {
// This is an optimization only. It is possible for the peer to be stopped // This is an optimization only. It is possible for the peer to be stopped
// immediately after this check, in which case, elem will get processed. // immediately after this check, in which case, elem will get processed.
// The timers and SendBuffer code are resilient to a few stragglers. // The timers and SendBuffer code are resilient to a few stragglers.
// TODO(josharian): rework peer shutdown order to ensure // TODO: rework peer shutdown order to ensure
// that we never accidentally keep timers alive longer than necessary. // that we never accidentally keep timers alive longer than necessary.
device.PutMessageBuffer(elem.buffer) device.PutMessageBuffer(elem.buffer)
device.PutOutboundElement(elem) device.PutOutboundElement(elem)

4
tun/tuntest/tuntest.go
View File

@ -113,7 +113,7 @@ func (t *chTun) File() *os.File { return nil }
func (t *chTun) Read(data []byte, offset int) (int, error) { func (t *chTun) Read(data []byte, offset int) (int, error) {
select { select {
case <-t.c.closed: case <-t.c.closed:
return 0, io.EOF // TODO(crawshaw): what is the correct error value? return 0, os.ErrClosed
case msg := <-t.c.Outbound: case msg := <-t.c.Outbound:
return copy(data[offset:], msg), nil return copy(data[offset:], msg), nil
} }
@ -130,7 +130,7 @@ func (t *chTun) Write(data []byte, offset int) (int, error) {
copy(msg, data[offset:]) copy(msg, data[offset:])
select { select {
case <-t.c.closed: case <-t.c.closed:
return 0, io.EOF // TODO(crawshaw): what is the correct error value? return 0, os.ErrClosed
case t.c.Inbound <- msg: case t.c.Inbound <- msg:
return len(data) - offset, nil return len(data) - offset, nil
} }