From 33c35284305e0c70e014bac2bcc3eada070aba26 Mon Sep 17 00:00:00 2001 From: Simon Rozman Date: Fri, 8 Mar 2019 09:43:54 +0100 Subject: [PATCH] wintun: Fix double-quoted strings escaping on output Signed-off-by: Simon Rozman --- tun/wintun/setupapi/setupapi_windows.go | 2 +- tun/wintun/wintun_windows.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tun/wintun/setupapi/setupapi_windows.go b/tun/wintun/setupapi/setupapi_windows.go index 5f9e05c..486a1ff 100644 --- a/tun/wintun/setupapi/setupapi_windows.go +++ b/tun/wintun/setupapi/setupapi_windows.go @@ -257,7 +257,7 @@ func (deviceInfoSet DevInfo) GetInterfaceID(deviceInfoData *DevInfoData) (*windo // Convert to windows.GUID. ifid, err := guid.FromString(value) if err != nil { - return nil, fmt.Errorf("NetCfgInstanceId registry value is not a GUID (expected: \"{...}\", provided: \"%v\")", value) + return nil, fmt.Errorf("NetCfgInstanceId registry value is not a GUID (expected: \"{...}\", provided: %q)", value) } return ifid, nil diff --git a/tun/wintun/wintun_windows.go b/tun/wintun/wintun_windows.go index eb72447..12fa11c 100644 --- a/tun/wintun/wintun_windows.go +++ b/tun/wintun/wintun_windows.go @@ -216,7 +216,7 @@ func CreateInterface(description string, hwndParent uintptr) (*Wintun, bool, err } if driverVersion == 0 { - return nil, false, fmt.Errorf("No driver for device \"%v\" installed", hardwareID) + return nil, false, fmt.Errorf("No driver for device %q installed", hardwareID) } // Call appropriate class installer. @@ -266,7 +266,7 @@ func CreateInterface(description string, hwndParent uintptr) (*Wintun, bool, err // Convert to windows.GUID. ifid, err := guid.FromString(value) if err != nil { - return nil, fmt.Errorf("NetCfgInstanceId registry value is not a GUID (expected: \"{...}\", provided: \"%v\")", value) + return nil, fmt.Errorf("NetCfgInstanceId registry value is not a GUID (expected: \"{...}\", provided: %q)", value) } wintun := (*Wintun)(ifid) @@ -277,7 +277,7 @@ func CreateInterface(description string, hwndParent uintptr) (*Wintun, bool, err return nil, err } - return nil, errors.New(fmt.Sprintf("RegOpenKeyEx(\"%v\") failed: ", keyNetName) + err.Error()) + return nil, errors.New(fmt.Sprintf("RegOpenKeyEx(%q) failed: ", keyNetName) + err.Error()) } defer keyNet.Close()