Hesham/wireguard-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FileConfigStore: Warn for deletion failure in exception path

Browse Source 
There's nothing we can do about it at this point; we're already rolling
back changes.

Signed-off-by: Samuel Holland <samuel@sholland.org>
This commit is contained in:
Samuel Holland 2018-01-18 04:12:54 -06:00
parent 23535c0577
commit c683d23125
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/wireguard/android/configStore/FileConfigStore.java
View File

@ -77,7 +77,8 @@ public final class FileConfigStore implements ConfigStore {
if (!replacementFile.createNewFile()) if (!replacementFile.createNewFile())
throw new IOException("Configuration for " + replacement + " already exists"); throw new IOException("Configuration for " + replacement + " already exists");
if (!file.renameTo(replacementFile)) { if (!file.renameTo(replacementFile)) {
replacementFile.delete(); if (!replacementFile.delete())
Log.w(TAG, "Couldn't delete marker file for new name " + replacement);
throw new IOException("Cannot rename configuration file " + file.getName()); throw new IOException("Cannot rename configuration file " + file.getName());
} }
} }