From 6c8a4a6a283ceaa4450e6c971801fe40d453c31a Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Thu, 12 Mar 2020 17:12:31 +0530
Subject: [PATCH] tunnel: Remove MISSING_VALUE from BadConfigException reasons

This is covered under SYNTAX_ERROR which feels like a reasonable choice,
so get rid of this unused field and associated resource string.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
---
 .../src/main/java/com/wireguard/config/BadConfigException.java   | 1 -
 ui/src/main/java/com/wireguard/android/util/ErrorMessages.java   | 1 -
 ui/src/main/res/values-hi/strings.xml                            | 1 -
 ui/src/main/res/values-it/strings.xml                            | 1 -
 ui/src/main/res/values-ja/strings.xml                            | 1 -
 ui/src/main/res/values-ru/strings.xml                            | 1 -
 ui/src/main/res/values-zh-rCN/strings.xml                        | 1 -
 ui/src/main/res/values/strings.xml                               | 1 -
 8 files changed, 8 deletions(-)

diff --git a/tunnel/src/main/java/com/wireguard/config/BadConfigException.java b/tunnel/src/main/java/com/wireguard/config/BadConfigException.java
index f1577e91..49fb39af 100644
--- a/tunnel/src/main/java/com/wireguard/config/BadConfigException.java
+++ b/tunnel/src/main/java/com/wireguard/config/BadConfigException.java
@@ -96,7 +96,6 @@ public class BadConfigException extends Exception {
         INVALID_VALUE,
         MISSING_ATTRIBUTE,
         MISSING_SECTION,
-        MISSING_VALUE,
         SYNTAX_ERROR,
         UNKNOWN_ATTRIBUTE,
         UNKNOWN_SECTION
diff --git a/ui/src/main/java/com/wireguard/android/util/ErrorMessages.java b/ui/src/main/java/com/wireguard/android/util/ErrorMessages.java
index e266cfed..98eac3e6 100644
--- a/ui/src/main/java/com/wireguard/android/util/ErrorMessages.java
+++ b/ui/src/main/java/com/wireguard/android/util/ErrorMessages.java
@@ -37,7 +37,6 @@ public final class ErrorMessages {
             BadConfigException.Reason.INVALID_VALUE, R.string.bad_config_reason_invalid_value,
             BadConfigException.Reason.MISSING_ATTRIBUTE, R.string.bad_config_reason_missing_attribute,
             BadConfigException.Reason.MISSING_SECTION, R.string.bad_config_reason_missing_section,
-            BadConfigException.Reason.MISSING_VALUE, R.string.bad_config_reason_missing_value,
             BadConfigException.Reason.SYNTAX_ERROR, R.string.bad_config_reason_syntax_error,
             BadConfigException.Reason.UNKNOWN_ATTRIBUTE, R.string.bad_config_reason_unknown_attribute,
             BadConfigException.Reason.UNKNOWN_SECTION, R.string.bad_config_reason_unknown_section
diff --git a/ui/src/main/res/values-hi/strings.xml b/ui/src/main/res/values-hi/strings.xml
index a98cb13a..7cfb4866 100644
--- a/ui/src/main/res/values-hi/strings.xml
+++ b/ui/src/main/res/values-hi/strings.xml
@@ -39,7 +39,6 @@
     <string name="bad_config_reason_invalid_value">अमान्य मूल्य</string>
     <string name="bad_config_reason_missing_attribute">गुम विशेषता</string>
     <string name="bad_config_reason_missing_section">छूटा हुआ भाग</string>
-    <string name="bad_config_reason_missing_value">अनुपस्थित मान</string>
     <string name="bad_config_reason_syntax_error">वक्य रचना त्रुटि</string>
     <string name="bad_config_reason_unknown_attribute">अज्ञात एट्रिब्यूट</string>
     <string name="bad_config_reason_unknown_section">अज्ञात एट्रिब्यूट </string>
diff --git a/ui/src/main/res/values-it/strings.xml b/ui/src/main/res/values-it/strings.xml
index 6cd08221..28b8aefb 100644
--- a/ui/src/main/res/values-it/strings.xml
+++ b/ui/src/main/res/values-it/strings.xml
@@ -39,7 +39,6 @@
     <string name="bad_config_reason_invalid_value">Valore non valido</string>
     <string name="bad_config_reason_missing_attribute">Attributo mancante</string>
     <string name="bad_config_reason_missing_section">Sezione mancante</string>
-    <string name="bad_config_reason_missing_value">Valore mancante</string>
     <string name="bad_config_reason_syntax_error">Errore di sintassi</string>
     <string name="bad_config_reason_unknown_attribute">Attributo sconosciuto</string>
     <string name="bad_config_reason_unknown_section">Sezione sconosciuta</string>
diff --git a/ui/src/main/res/values-ja/strings.xml b/ui/src/main/res/values-ja/strings.xml
index 58944bdc..3d35e396 100644
--- a/ui/src/main/res/values-ja/strings.xml
+++ b/ui/src/main/res/values-ja/strings.xml
@@ -33,7 +33,6 @@
     <string name="bad_config_reason_invalid_value">無効な値</string>
     <string name="bad_config_reason_missing_attribute">属性が不足しています</string>
     <string name="bad_config_reason_missing_section">セクションが不足しています</string>
-    <string name="bad_config_reason_missing_value">値が不足しています</string>
     <string name="bad_config_reason_syntax_error">構文エラー</string>
     <string name="bad_config_reason_unknown_attribute">未知の属性</string>
     <string name="bad_config_reason_unknown_section">未知のセクション</string>
diff --git a/ui/src/main/res/values-ru/strings.xml b/ui/src/main/res/values-ru/strings.xml
index 79b6ddc6..a3d86742 100644
--- a/ui/src/main/res/values-ru/strings.xml
+++ b/ui/src/main/res/values-ru/strings.xml
@@ -39,7 +39,6 @@
     <string name="bad_config_reason_invalid_value">Неправильное значение</string>
     <string name="bad_config_reason_missing_attribute">Несуществующий атрибут</string>
     <string name="bad_config_reason_missing_section">Несуществующий раздел</string>
-    <string name="bad_config_reason_missing_value">Несуществющее значение</string>
     <string name="bad_config_reason_syntax_error">Синтаксическая ошибка</string>
     <string name="bad_config_reason_unknown_attribute">Неизвестный атрибут</string>
     <string name="bad_config_reason_unknown_section">Неизвестный раздел</string>
diff --git a/ui/src/main/res/values-zh-rCN/strings.xml b/ui/src/main/res/values-zh-rCN/strings.xml
index d3243f95..b4ac5b26 100644
--- a/ui/src/main/res/values-zh-rCN/strings.xml
+++ b/ui/src/main/res/values-zh-rCN/strings.xml
@@ -33,7 +33,6 @@
     <string name="bad_config_reason_invalid_value">数值无效</string>
     <string name="bad_config_reason_missing_attribute">属性缺失</string>
     <string name="bad_config_reason_missing_section">节缺失</string>
-    <string name="bad_config_reason_missing_value">数值缺失</string>
     <string name="bad_config_reason_syntax_error">语法错误</string>
     <string name="bad_config_reason_unknown_attribute">属性未知</string>
     <string name="bad_config_reason_unknown_section">节未知</string>
diff --git a/ui/src/main/res/values/strings.xml b/ui/src/main/res/values/strings.xml
index 71d88930..6961c83a 100644
--- a/ui/src/main/res/values/strings.xml
+++ b/ui/src/main/res/values/strings.xml
@@ -39,7 +39,6 @@
     <string name="bad_config_reason_invalid_value">Invalid value</string>
     <string name="bad_config_reason_missing_attribute">Missing attribute</string>
     <string name="bad_config_reason_missing_section">Missing section</string>
-    <string name="bad_config_reason_missing_value">Missing value</string>
     <string name="bad_config_reason_syntax_error">Syntax error</string>
     <string name="bad_config_reason_unknown_attribute">Unknown attribute</string>
     <string name="bad_config_reason_unknown_section">Unknown section</string>