Hesham/wireguard-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address lint issues in TunnelListFragment

Browse Source 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
Harsh Shandilya 2018-07-12 01:20:38 +05:30 committed by Jason A. Donenfeld
parent 26d762bc5c
commit 19b57c41b7
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/java/com/wireguard/android/fragment/TunnelListFragment.java
View File

@ -45,7 +45,6 @@ import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.HashSet; import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Set;
import java.util.zip.ZipEntry; import java.util.zip.ZipEntry;
import java.util.zip.ZipInputStream; import java.util.zip.ZipInputStream;
@ -289,7 +288,7 @@ public class TunnelListFragment extends BaseFragment {
} }
private final class ActionModeListener implements ActionMode.Callback { private final class ActionModeListener implements ActionMode.Callback {
private final Set<Integer> checkedItems = new HashSet<>(); private final Collection<Integer> checkedItems = new HashSet<>();
private Resources resources; private Resources resources;
@ -297,8 +296,8 @@ public class TunnelListFragment extends BaseFragment {
public boolean onActionItemClicked(final ActionMode mode, final MenuItem item) { public boolean onActionItemClicked(final ActionMode mode, final MenuItem item) {
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.menu_action_delete: case R.id.menu_action_delete:
List<Tunnel> tunnelsToDelete = new ArrayList<>(); final Collection<Tunnel> tunnelsToDelete = new ArrayList<>();
for (Integer position : checkedItems) { for (final Integer position : checkedItems) {
tunnelsToDelete.add(Application.getTunnelManager().getTunnels().get(position)); tunnelsToDelete.add(Application.getTunnelManager().getTunnels().get(position));
} }
@ -341,11 +340,11 @@ public class TunnelListFragment extends BaseFragment {
binding.tunnelList.getAdapter().notifyDataSetChanged(); binding.tunnelList.getAdapter().notifyDataSetChanged();
} }
void toggleItemChecked(int position) { void toggleItemChecked(final int position) {
setItemChecked(position, !checkedItems.contains(position)); setItemChecked(position, !checkedItems.contains(position));
} }
void setItemChecked(int position, boolean checked) { void setItemChecked(final int position, final boolean checked) {
if (checked) { if (checked) {
checkedItems.add(position); checkedItems.add(position);
} else { } else {