Hesham/wireguard-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ModuleLoader: sync file before renaming

Browse Source 
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2019-10-22 15:04:54 +02:00
parent d40ac7f89d
commit 16890a659e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/wireguard/android/util/ModuleLoader.java
View File

@ -22,7 +22,6 @@ import java.io.File;
import java.io.FileOutputStream; import java.io.FileOutputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.OutputStream;
import java.net.HttpURLConnection; import java.net.HttpURLConnection;
import java.net.URL; import java.net.URL;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
@ -159,7 +158,7 @@ public class ModuleLoader {
tempFile = File.createTempFile("UNVERIFIED-", null, tmpDir); tempFile = File.createTempFile("UNVERIFIED-", null, tmpDir);
MessageDigest digest = MessageDigest.getInstance("SHA-256"); MessageDigest digest = MessageDigest.getInstance("SHA-256");
try (final InputStream inputStream = connection.getInputStream(); try (final InputStream inputStream = connection.getInputStream();
final OutputStream outputStream = new FileOutputStream(tempFile)) { final FileOutputStream outputStream = new FileOutputStream(tempFile)) {
int total = 0; int total = 0;
while ((len = inputStream.read(input)) > 0) { while ((len = inputStream.read(input)) > 0) {
total += len; total += len;
@ -168,6 +167,7 @@ public class ModuleLoader {
outputStream.write(input, 0, len); outputStream.write(input, 0, len);
digest.update(input, 0, len); digest.update(input, 0, len);
} }
outputStream.getFD().sync();
} }
if (!Arrays.equals(digest.digest(), modules.get(moduleName).bytes)) if (!Arrays.equals(digest.digest(), modules.get(moduleName).bytes))
throw new IOException("Incorrect file hash"); throw new IOException("Incorrect file hash");