From bf5b170101b287082637ef729feee983f8cda36a Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Thu, 8 Jul 2021 02:50:06 +0200 Subject: [PATCH] api: print correct last error when failing Prior to the conversion, LastError is ERROR_SUCCESS, so move the logging to be after the conversion. Signed-off-by: Jason A. Donenfeld --- api/adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/adapter.c b/api/adapter.c index 3134b6d..0fe902f 100644 --- a/api/adapter.c +++ b/api/adapter.c @@ -1747,10 +1747,10 @@ static _Return_type_success_(return != NULL) WINTUN_ADAPTER *CreateAdapter( 0) || PropertyType != DEVPROP_TYPE_INT32) ProblemCode = 0; - LOG_ERROR(LastError, L"Failed to setup adapter (code: 0x%x, status: 0x%x)", ProblemCode, ProblemStatus); LastError = RtlNtStatusToDosError(ProblemStatus); if (LastError == ERROR_SUCCESS) LastError = ERROR_NOT_READY; + LOG_ERROR(LastError, L"Failed to setup adapter (code: 0x%x, status: 0x%x)", ProblemCode, ProblemStatus); goto cleanupTcpipAdapterRegKey; } Sleep(10);