Hesham/wintun
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

api: tighten function parameter code analysis annotations

Browse Source 
Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2021-02-02 12:53:40 +01:00
parent 41b77964ca
commit 542a281808
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
api/adapter.c
View File

@ -178,7 +178,7 @@ IsOurAdapter(_In_ HDEVINFO DevInfo, _In_ SP_DEVINFO_DATA *DevInfoData)
return IsOurs; return IsOurs;
} }
static _Return_type_success_(return != NULL) WCHAR *GetDeviceObjectFileName(_In_opt_z_ const WCHAR *InstanceId) static _Return_type_success_(return != NULL) WCHAR *GetDeviceObjectFileName(_In_z_ const WCHAR *InstanceId)
{ {
ULONG InterfacesLen; ULONG InterfacesLen;
DWORD LastError = CM_MapCrToWin32Err( DWORD LastError = CM_MapCrToWin32Err(
@ -214,7 +214,7 @@ static _Return_type_success_(return != NULL) WCHAR *GetDeviceObjectFileName(_In_
return Interfaces; return Interfaces;
} }
static _Return_type_success_(return != INVALID_HANDLE_VALUE) HANDLE OpenDeviceObject(_In_opt_z_ const WCHAR *InstanceId) static _Return_type_success_(return != INVALID_HANDLE_VALUE) HANDLE OpenDeviceObject(_In_z_ const WCHAR *InstanceId)
{ {
WCHAR *Filename = GetDeviceObjectFileName(InstanceId); WCHAR *Filename = GetDeviceObjectFileName(InstanceId);
if (!Filename) if (!Filename)
@ -234,7 +234,7 @@ static _Return_type_success_(return != INVALID_HANDLE_VALUE) HANDLE OpenDeviceOb
} }
static BOOL static BOOL
EnsureDeviceObject(_In_opt_z_ const WCHAR *InstanceId) EnsureDeviceObject(_In_z_ const WCHAR *InstanceId)
{ {
WCHAR *Filename = GetDeviceObjectFileName(InstanceId); WCHAR *Filename = GetDeviceObjectFileName(InstanceId);
if (!Filename) if (!Filename)
@ -426,8 +426,7 @@ static _Return_type_success_(return != FALSE) BOOL
return TRUE; return TRUE;
} }
static _Return_type_success_(return != FALSE) BOOL static _Return_type_success_(return != FALSE) BOOL GetNetCfgInstanceIdFromHKEY(_In_ HKEY Key, _Out_ GUID *CfgInstanceID)
GetNetCfgInstanceIdFromHKEY(_In_ HKEY Key, _Out_ GUID *CfgInstanceID)
{ {
WCHAR *ValueStr = RegistryQueryString(Key, L"NetCfgInstanceId", TRUE); WCHAR *ValueStr = RegistryQueryString(Key, L"NetCfgInstanceId", TRUE);
if (!ValueStr) if (!ValueStr)
@ -1184,7 +1183,7 @@ EnsureWintunUnloaded(void)
static _Return_type_success_(return != FALSE) BOOL SelectDriver( static _Return_type_success_(return != FALSE) BOOL SelectDriver(
_In_ HDEVINFO DevInfo, _In_ HDEVINFO DevInfo,
_In_opt_ SP_DEVINFO_DATA *DevInfoData, _In_ SP_DEVINFO_DATA *DevInfoData,
_Inout_ SP_DEVINSTALL_PARAMS_W *DevInstallParams) _Inout_ SP_DEVINSTALL_PARAMS_W *DevInstallParams)
{ {
static const FILETIME OurDriverDate = WINTUN_INF_FILETIME; static const FILETIME OurDriverDate = WINTUN_INF_FILETIME;